-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @swc/plugin-styled-components from 1.5.122 to 2.0.10 #44433
Bump @swc/plugin-styled-components from 1.5.122 to 2.0.10 #44433
Conversation
Bumps [@swc/plugin-styled-components](https://github.com/swc-project/plugins) from 1.5.122 to 2.0.10. - [Commits](https://github.com/swc-project/plugins/commits) --- updated-dependencies: - dependency-name: "@swc/plugin-styled-components" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
d6d8001
to
5031990
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this just works considering the mess that is getting SWC plugins to all agree with each other but sure
edit: I didn't test this, it was an (incorrect) guess cos CI passed 😅 - @bl-nero tested it locally and the dev server is broken. Strange that CI passed.
Bumped the |
@@ -21,7 +21,8 @@ | |||
"@storybook/addon-toolbars": "^6.5.16", | |||
"@storybook/builder-webpack5": "^6.5.16", | |||
"@storybook/manager-webpack5": "^6.5.16", | |||
"@swc/plugin-styled-components": "^1.5.122", | |||
"@swc/core": "^1.7.0", | |||
"@swc/plugin-styled-components": "^2.0.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking through the setup instructions for this plugin and I found a comment about swc not supporting pure
:
teleport/web/packages/build/vite/react.mjs
Lines 36 to 53 in fb60c97
// https://nextjs.org/docs/advanced-features/compiler#styled-components | |
if (mode === 'production') { | |
return { | |
ssr: false, | |
pure: false, // not currently supported by SWC | |
displayName: false, | |
fileName: false, | |
cssProp: true, | |
}; | |
} | |
return { | |
ssr: false, | |
pure: true, // not currently supported by SWC | |
displayName: true, | |
fileName: true, | |
cssProp: true, | |
}; |
Then I followed the link to the Next.js docs from the same file, which points to vercel/next.js#30802 as to why pure
is not supported yet. But it seems like this was actually implemented a couple of months ago: swc-project/plugins#238
@ryanclark, do you think we could enable this in prod? I'm not sure if it makes any difference, but hey at least it should be supported now. I didn't want to block the PR on this because enabling that option and upgrading swc are separate issues.
Bumps @swc/plugin-styled-components from 1.5.122 to 2.0.10.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)