Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] fix: Bypass OS compat workflow until GLIBC is fixed #43827

Merged
merged 1 commit into from
Jul 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 35 additions & 29 deletions .github/workflows/os-compatibility-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,24 @@ jobs:
WEBASSETS_SKIP_BUILD: 1

steps:
- name: Checkout Teleport
uses: actions/checkout@v3 # Cannot upgrade to v4 while this runs in centos:7 due to nodejs GLIBC incompatibility
- name: Bypass
run: echo 'Bypassed until the nodejs 20 GLIBC issue is fixed'

- name: Prepare workspace
uses: ./.github/actions/prepare-workspace

- name: Run make
run: |
make binaries FIDO2=static

- name: Upload binaries
uses: actions/upload-artifact@v3
with:
name: build
path: ${{ github.workspace }}/build/
# - name: Checkout Teleport
# uses: actions/checkout@v3 # Cannot upgrade to v4 while this runs in centos:7 due to nodejs GLIBC incompatibility
#
# - name: Prepare workspace
# uses: ./.github/actions/prepare-workspace
#
# - name: Run make
# run: |
# make binaries FIDO2=static
#
# - name: Upload binaries
# uses: actions/upload-artifact@v3
# with:
# name: build
# path: ${{ github.workspace }}/build/

test-compat:
needs: build
Expand All @@ -55,19 +58,22 @@ jobs:
contents: read

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Download binaries
uses: actions/download-artifact@v3
with:
name: build
path: ${{ github.workspace }}/build

- name: chmod +x
run: chmod +x ${GITHUB_WORKSPACE}/build/*
- name: Bypass
run: echo 'Bypassed until the nodejs 20 GLIBC issue is fixed'

- name: Run compat matrix
timeout-minutes: 10
run: |
cd ${GITHUB_WORKSPACE} && ./build.assets/build-test-compat.sh
# - name: Checkout
# uses: actions/checkout@v4
#
# - name: Download binaries
# uses: actions/download-artifact@v3
# with:
# name: build
# path: ${{ github.workspace }}/build
#
# - name: chmod +x
# run: chmod +x ${GITHUB_WORKSPACE}/build/*
#
# - name: Run compat matrix
# timeout-minutes: 10
# run: |
# cd ${GITHUB_WORKSPACE} && ./build.assets/build-test-compat.sh
Loading