[v14] Add context around AWS join methods #43818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptgott
added
the
no-changelog
marcoandredinis
approved these changes
Jul 5, 2024
strideynet
approved these changes
Jul 5, 2024
ptgott
force-pushed
the
bot/backport-43380-branch/v14
branch
from
217c91e to
f013217
Compare
ptgott
force-pushed
the
bot/backport-43380-branch/v14
branch
from
f013217 to
36653c9
Compare
ptgott
force-pushed
the
bot/backport-43380-branch/v14
branch
from
36653c9 to
73c52e3
Compare
Closes #26893 Help users determine whether to use the EC2 or IAM join method by: - Adding a "How it works" section to the top of each method's how-to guide explaining how the join method works. - Ensuring that both guides include a brief discussion of alternative possibilities. Currently, only one of these guides does.
ptgott
force-pushed
the
bot/backport-43380-branch/v14
branch
from
73c52e3 to
577b735
Compare
|
@mmcallister Checking to see if you have a moment to review this one. Thanks! |
mmcallister
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #43380 to branch/v14