Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address staticcheck false positives #43800

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Address staticcheck false positives #43800

merged 1 commit into from
Jul 3, 2024

Conversation

codingllama
Copy link
Contributor

Addresses false positives on macOS.

Sadly we need all three lines, otherwise it still gets flagged.

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Jul 3, 2024
@github-actions github-actions bot requested review from justinas and ravicious July 3, 2024 15:23
@codingllama
Copy link
Contributor Author

FYI @atburke.

@codingllama codingllama enabled auto-merge July 3, 2024 21:18
@codingllama codingllama added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit ff9988f Jul 3, 2024
39 of 40 checks passed
@codingllama codingllama deleted the codingllama/statichehck-false-positives branch July 3, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugoShaka hugoShaka hugoShaka approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codingllama @zmb3 @hugoShaka