-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eBPF on RHEL 9 family systems #43783
Conversation
I compiled Teleport from LGTM. |
f08d853
to
be630c0
Compare
Friendly ping @fheinecke @fspmarshall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of impact does this have on other distros and kernel versions? Could this break any existing users of enhanced recording?
I tested it with a few other distros that were previously not affected but this bug, but I cannot get you the guaranty that it will work with every possible Linux kernel version and every fork. This patch is based on multiple other OSS repos that were fixing the same issue. |
I tried to test my binary on my existing Amazon Linux 2 box where BPF works today, but unfortunately I compiled it on a box with a newer glibc version so it won't run. I think I'd have to put it through CI to get a usable CentOS 7-built binary (not sure what that process looks like today). If you'd like me to test it on AL2 and can provide a binary, I'm happy to. |
Fix
failed to attach to tracepoint 'syscalls/sys_exit_execve': Permission denied
error that happens on RHEL 9 systems.Background:
Our code was incorrect in the first place. As described here torvalds/linux@ba8ea72 we should be using
syscall_trace_*
from the very beginning. The only reason why this code used to work in the first place was the same size oftrace_event_raw_sys_*
andsyscall_trace_*
structs. When theraw
version was modified or code failed to load as the provided struct had a wrong size.Closes #35286
changelog: Fix eBPF error occuring during startup on Linux RHEL 9