-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update Discover flow to support update resource mechanism #43774
Conversation
|
||
renderUpdate({ resourceSpecForUpdate: resourceSpecForUpdate }); | ||
|
||
expect(screen.queryAllByTestId(ResourceKind.Server).length).toBeFalsy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure if this (queryAllByTestId().length).toBeFalsy()
) is the correct way to check that resources are not rendered for the update flow. lmk if theres a better way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe:
expect(screen.queryByTestId((ResourceKind.Server)).not.toBeInTheDocument();
|
||
renderUpdate({ resourceSpecForUpdate: resourceSpecForUpdate }); | ||
|
||
expect(screen.queryAllByTestId(ResourceKind.Server).length).toBeFalsy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe:
expect(screen.queryByTestId((ResourceKind.Server)).not.toBeInTheDocument();
Friendly ping. |
As this one is pending review, I am closing it and I instead I will add these changes to the followup #43871 which depends on this one and implements the changes required for supporting SAMl app update flow as a whole. |
Updates
DiscoverComponent
component anduseDiscover
to support update resource mechanism.A new props
updateFlow
have been added of typeDiscoverUpdateProps
:Implemented to support SAML application update flow - https://github.com/gravitational/teleport.e/issues/4458