Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add audit events for integration resource actions #43767

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

capnspacehook
Copy link
Contributor

Fixes https://github.com/gravitational/teleport-private/issues/1456.

changelog: added audit events for AWS and Azure integration resource actions

Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoandredinis Can you review this as well?

api/proto/teleport/legacy/types/events/events.proto Outdated Show resolved Hide resolved
lib/events/codes.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capnspacehook Do not forget to make a corresponding frontend change so that these events render properly.

@capnspacehook capnspacehook enabled auto-merge July 3, 2024 04:16
@capnspacehook capnspacehook disabled auto-merge July 3, 2024 04:16
@capnspacehook capnspacehook force-pushed the capnspacehook/integration-audit branch from f414f0e to b2ef7df Compare July 3, 2024 15:09
@capnspacehook
Copy link
Contributor Author

To make it easier I decided to add the Web UI changes here too.

@capnspacehook capnspacehook force-pushed the capnspacehook/integration-audit branch 2 times, most recently from 020e8ac to 5b029a9 Compare July 8, 2024 20:29
@capnspacehook capnspacehook enabled auto-merge July 8, 2024 20:29
@capnspacehook capnspacehook force-pushed the capnspacehook/integration-audit branch 3 times, most recently from caaec7b to 7fb6ae3 Compare July 13, 2024 01:07
@capnspacehook capnspacehook force-pushed the capnspacehook/integration-audit branch from 7fb6ae3 to eaa041a Compare July 15, 2024 23:27
@capnspacehook capnspacehook added this pull request to the merge queue Jul 15, 2024
Merged via the queue into master with commit 12e1179 Jul 16, 2024
43 checks passed
@capnspacehook capnspacehook deleted the capnspacehook/integration-audit branch July 16, 2024 00:05
@public-teleport-github-review-bot

@capnspacehook See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Failed
branch/v16 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants