[v14] Remove direct dependency on github.com/hashicorp/go-version #43744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
backport
no-changelog
rosstimothy
force-pushed
the
tross/backport-43735/v14
branch
from
9e530a5 to
4a754a8
Compare
Teleport had 3 dependencies to parse semantic versions: - golang.org/x/mod/semver - github.com/coreos/go-semver/semver - github.com/hashicorp/go-version The last of the three was only used in `integrations/lib.AssertServerVersion` which was a clone of `lib/utils.CheckVersion`. By converting all code in integrations to use `lib/utils.CheckVersion` the direct dependency on github.com/hashicorp/go-version can be dropped. The depguard rules have also been updated to prevent it from sneaking back into the dependency tree. A follow up change will further consolidate semver dependencies to a single package.
rosstimothy
force-pushed
the
tross/backport-43735/v14
branch
from
4a754a8 to
ec248bf
Compare
zmb3
approved these changes
Jul 2, 2024
tigrato
approved these changes
Jul 2, 2024
public-teleport-github-review-bot
bot
removed the request for review
from marcoandredinis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #43735 to branch/v14