Add support for SAML SLO in tsh
#43528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
the
no-changelog
github-actions
bot
added
size/sm
tsh
espadolini
reviewed
Jun 26, 2024
@espadolini It will log them out of all their IdP sessions, this might not seem ideal but it's just the way SAML SLO works. There was discussion about this here in the original issue. |
espadolini
reviewed
Jun 27, 2024
There was a problem hiding this comment.
I would really prefer if we had a way to keep track of whether or not the login was a SSO session to begin with and if it had a SLO url, since I'm really not looking forward to tsh logout taking 5 seconds per profile, and I'd just start doing rm -r ~/.tsh instead.
rudream
force-pushed
the
yassine/saml-slo-tsh
branch
2 times, most recently
from
527791d to
3ded2d8
Compare
espadolini
reviewed
Jul 11, 2024
espadolini
approved these changes
Jul 12, 2024
avatus
approved these changes
Jul 12, 2024
rudream
force-pushed
the
yassine/saml-slo-tsh
branch
from
6308361 to
75eadc5
Compare
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #41076
This PR adds SAML SLO (single logout) functionality to
tsh. When a user runstsh logout, if they were logged in via a SAML auth connector with SLO configured, they will also be logged out of the identity provider.