-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check that an FQDN belongs to a known app before redirecting to it #43525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
capnspacehook
commented
Jun 26, 2024
capnspacehook
force-pushed
the
capnspacehook/open-url-redirect-fix
branch
3 times, most recently
from
June 27, 2024 17:11
9c39278
to
e0217a3
Compare
kimlisa
approved these changes
Jun 27, 2024
avatus
approved these changes
Jul 1, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ibeckermayer
July 1, 2024 02:25
capnspacehook
force-pushed
the
capnspacehook/open-url-redirect-fix
branch
from
July 2, 2024 14:53
e0217a3
to
6a9571e
Compare
capnspacehook
force-pushed
the
capnspacehook/open-url-redirect-fix
branch
from
July 8, 2024 20:25
ff1259d
to
e679a09
Compare
@capnspacehook See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/gravitational/teleport-private/issues/1418 on how to test this.
Fixes https://github.com/gravitational/teleport-private/issues/1492, updates https://github.com/gravitational/teleport-private/issues/1418.
changelog: prevent redirects to arbitrary URLs when launching an app