Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine ID: Render kubernetes template without exec plugin when using non-directory destination #43401

Merged

Conversation

strideynet
Copy link
Contributor

A few customers have run into "must be a directory in exec plugin mode" - whilst there's a configurable option for this, it makes more sense for tbot to just default to enabling this setting to reduce friction. This should reduce support load.

changelog: Machine ID defaults to disabling the use of the Kubernetes exec plugin when writing a Kubeconfig to a directory destination. This removes the need to manually configure disable_exec_plugin.

@strideynet
Copy link
Contributor Author

CC @webvictim

lib/tbot/config/template_kubernetes.go Outdated Show resolved Hide resolved
lib/tbot/config/template_kubernetes.go Outdated Show resolved Hide resolved
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from timothyb89 June 25, 2024 08:41
@strideynet strideynet enabled auto-merge June 25, 2024 13:18
@strideynet strideynet added this pull request to the merge queue Jun 25, 2024
Merged via the queue into master with commit 014a847 Jun 25, 2024
37 checks passed
@strideynet strideynet deleted the strideynet/output-kubernetes-template-without-exec-plugin branch June 25, 2024 14:05
@public-teleport-github-review-bot

@strideynet See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants