Fix reliance on DNS resolution of *.localhost in tbot tests
#43400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
added
backport/branch/v15
backport/branch/v16
no-changelog
tigrato
approved these changes
Jun 24, 2024
marcoandredinis
approved these changes
Jun 24, 2024
public-teleport-github-review-bot
bot
removed the request for review
from timothyb89
zmb3
approved these changes
Jun 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
strideynet
deleted the
strideynet/fix-tbot-reliance-on-dns-resolution-in-tests
branch
|
@strideynet See the table below for backport results.
|
This was referenced Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had boldly assumed that the convention/standards that stated that any subdomain of
localhostwould resolve to 127.00.1 would be abided by - unfortunately it looks like this isn't the case on our self-hosted runners which run the nightly flake tests. This should resolve the failing nightly flakes fortbot.