-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tool to check for missing docs redirects #43351
Conversation
🤖 Vercel preview here: https://docs-p8urggj21-goteleport.vercel.app/docs/ver/preview |
Add a tool to check for URL paths in the Teleport docs site that do not correspond to actual docs pages or redirects. These URLs are most likely links that will 404 if a user follows them. This way, we can be more strategic about the redirects that we configure for the docs site, meaning that we do not need to add redirects for every single docs page that we rename or delete. A later change can add a GitHub Actions workflow to run the program.
a550302
to
bb61cbd
Compare
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
🤖 Vercel preview here: https://docs-9hfwhdkz9-goteleport.vercel.app/docs/ver/preview |
🤖 Vercel preview here: https://docs-fesg8fcho-goteleport.vercel.app/docs/ver/preview |
This comment was marked as resolved.
This comment was marked as resolved.
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks
🤖 Vercel preview here: https://docs-fo4b1732x-goteleport.vercel.app/docs/ver/preview |
- Clarify the `--in` flag. - Add a more descriptive name for missing directory entries. - Explicitly check `docsURLs` length - Use a Set for the internal redirects field
b53c3a0
to
144cfcd
Compare
🤖 Vercel preview here: https://docs-e5cs8k2ck-goteleport.vercel.app/docs/ver/preview |
Add a tool to check for URL paths in the Teleport docs site that do not correspond to actual docs pages or redirects. These URLs are most likely links that will 404 if a user follows them. This way, we can be more strategic about the redirects that we configure for the docs site, meaning that we do not need to add redirects for every single docs page that we rename or delete. A later change can add a GitHub Actions workflow to run the program.