Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use correct libfido2 version on Dockerfile-centos7 #43317

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: Use correct libfido2 version on Dockerfile-centos7 #43317

merged 1 commit into from
Jun 20, 2024

Conversation

codingllama
Copy link
Contributor

#43123 updated the libfido2 version but forgot to change the copies on Dockerfile-centos7.

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Jun 20, 2024
@github-actions github-actions bot requested review from kimlisa and tcsc June 20, 2024 20:39
rosstimothy
rosstimothy approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this resolves issues by running tag builds with and without this change

@codingllama
Copy link
Contributor Author

Confirmed via make enter/centos7 and poking around too.

@codingllama codingllama enabled auto-merge June 20, 2024 20:48
@codingllama codingllama added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@codingllama codingllama added this pull request to the merge queue Jun 20, 2024
Merged via the queue into master with commit e673a7a Jun 20, 2024
39 of 40 checks passed
@codingllama codingllama deleted the codingllama/libfido2-centos7 branch June 20, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy approved these changes

@marcoandredinis marcoandredinis marcoandredinis approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codingllama @marcoandredinis @rosstimothy