Reorganize the color palette #43304
Merged
Reorganize the color palette #43304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl-nero
added
the
no-changelog
ravicious
approved these changes
Jun 21, 2024
| {word} | ||
| {i < arr.length - 1 ? '.' : ''} | ||
| {/*potential line break*/} | ||
| <wbr /> |
| @@ -87,13 +104,15 @@ export type ThemeColors = { | |||
| textDisabled: string; | |||
| bgDisabled: string; | |||
|
|
|||
| /** @deprecated Use `interactive.solid.primary` instead. */ | |||
There was a problem hiding this comment.
Oh, that is huge that this now works properly thanks to types in UI components.
There was a problem hiding this comment.
Unfortunately, only in style functions, but the usage of colors in attributes is somehow limited to just a handful of cases.
gzdunek
approved these changes
Jun 21, 2024
Co-authored-by: Rafał Cieślak <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
bl-nero
added a commit
that referenced
this pull request
Oct 11, 2024
* Reorganize the color palette * Update web/packages/design/src/theme/themeColors.story.tsx Co-authored-by: Rafał Cieślak <[email protected]> * review --------- Co-authored-by: Rafał Cieślak <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Reorganize the color palette (#43304) * Reorganize the color palette * Update web/packages/design/src/theme/themeColors.story.tsx Co-authored-by: Rafał Cieślak <[email protected]> * review --------- Co-authored-by: Rafał Cieślak <[email protected]> * Get rid of unnecessary text colors (#47458) * wip * wip * Remove the background field * Remove the type * Post-merge fix --------- Co-authored-by: Rafał Cieślak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change puts together color combinations that are defined by the new design system. Most of these colors were already there, but scattered and disorganized. This change deprecates the old fields and introduces new ones that have text and background colors grouped together and are intended to serve as the source of truth.
This is a preparation step for the upcoming change that implements the new button system.
There are no visible changes expected.
Note: This change is coupled with https://github.com/gravitational/teleport.e/pull/4457, but (hopefully) not enough to break the build or tests.