[v15] Refactor imds/gcp to no longer depend on lib/cloud/gcp #43272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
backport
no-changelog
rosstimothy
force-pushed
the
tross/backport-43122/v15
branch
from
0879e23 to
847f214
Compare
The imds pacakges are inteneded to be very lightweight and consumable by client tools without any additional cloud specific dependencies. By inverting dependencies such that lib/cloud/gcp depends on lib/cloud/imds/gcp client tools no longer transatively import the very large `cloud.google.com/go/compute/apiv1`. The depguard rules were also updated to prevent any accidental regressions.
rosstimothy
force-pushed
the
tross/backport-43122/v15
branch
from
847f214 to
c38c930
Compare
atburke
approved these changes
Jun 20, 2024
zmb3
approved these changes
Jun 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #43122 and #43122 to branch/v15