Use libfido2 on builds if present #43224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
added
backport/branch/v14
no-changelog
rosstimothy
approved these changes
Jun 18, 2024
GavinFrazar
approved these changes
Jun 18, 2024
tigrato
approved these changes
Jun 18, 2024
zmb3
approved these changes
Jun 19, 2024
codingllama
requested review from
klizhentas,
russjones,
r0mant,
fheinecke,
camscale and
tcsc
as code owners
|
FYI, I've changed the "OS Compatibility" builds to use static libfido2, as that better reflect our actual prod binaries (commit d0359df). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@codingllama See the table below for backport results.
|
rosstimothy
pushed a commit
that referenced
this pull request
Jun 20, 2024
* Use libfido2 on builds if present * Use static libfido2 linking on OS compat tests
rosstimothy
pushed a commit
that referenced
this pull request
Jun 20, 2024
* Use libfido2 on builds if present * Use static libfido2 linking on OS compat tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link dynamically to libfido2, by default, if it's present in the environment. Affects tsh and tctl builds.