Remove lib/devicetrust from lib/client #43186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
backport/branch/v14
no-changelog
rosstimothy
force-pushed
the
tross/refactor_dt_overrides
branch
2 times, most recently
from
edde3a8 to
3b50e37
Compare
github-actions
bot
added
size/sm
tsh
codingllama
reviewed
Jun 18, 2024
codingllama
approved these changes
Jun 18, 2024
|
@gzdunek would appreciate if you could double check that I've covered all places that Connect might be impacted by this change. |
gzdunek
approved these changes
Jun 19, 2024
public-teleport-github-review-bot
bot
removed the request for review
from smallinsky
@gzdunek you can get a local build going yourself, or one of us can send you a pre-built binary. I rarely do tag builds for dev only purposes. |
|
Thanks @codingllama. I tested device trust in Connect, works fine. |
The native device trust libraries included in lib/devicetrust prevent building client tools that don't use device trust from building with cgo disabled. This moves the default device auth ceremony and device enrollment from lib/client into a location specific to tsh since it's the only tool that requires them. Updates #43112.
rosstimothy
force-pushed
the
tross/refactor_dt_overrides
branch
from
46fe90b to
8a8db1c
Compare
|
@rosstimothy See the table below for backport results.
|
This was referenced Jun 20, 2024
rosstimothy
added a commit
that referenced
this pull request
Jun 20, 2024
The native device trust libraries included in lib/devicetrust prevent building client tools that don't use device trust from building with cgo disabled. This moves the default device auth ceremony and device enrollment from lib/client into a location specific to tsh since it's the only tool that requires them. Updates #43112.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
The native device trust libraries included in lib/devicetrust prevent building client tools that don't use device trust from building with cgo disabled. This moves the default device auth ceremony and device enrollment from lib/client into a location specific to tsh since it's the only tool that requires them. Updates #43112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native device trust libraries included in lib/devicetrust prevent building client tools that don't use device trust from building with cgo disabled. This moves the default device auth ceremony and device enrollment from lib/client into a location specific to tsh since it's the only tool that requires them.
Updates #43112.