Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a FieldCheckbox component #43171

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Add a FieldCheckbox component #43171

merged 2 commits into from
Jun 20, 2024

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented Jun 18, 2024

This PR adds a component for labeled checkboxes, as specified in Figma. It's the first in a chain of PRs that push this feature through our codebase without (hopefully) breaking the build on the OSS/Enterprise boundary.

Screenshot 2024-06-18 at 13 47 04

Screenshot 2024-06-18 at 13 29 07

Followed up by Enterprise PR https://github.com/gravitational/teleport.e/pull/4430
Followed up by OSS PR #43173
Contributes to #42573

Manual tests:

  • Login dialog in the Community Edition mode
  • Unified Resources: interacting with tiles and the filter panel
  • Editing AWS OIDC integration
  • Security group picker (EC2 Ice or automatically deploying a database service)

Also use it wherever applicable
@github-actions github-actions bot requested review from rudream and ryanclark June 18, 2024 11:52
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@bl-nero bl-nero added the no-changelog Indicates that a PR does not require a changelog entry label Jun 18, 2024
@bl-nero bl-nero added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@bl-nero bl-nero enabled auto-merge June 20, 2024 17:12
@bl-nero bl-nero added this pull request to the merge queue Jun 20, 2024
Merged via the queue into master with commit 894dccc Jun 20, 2024
37 checks passed
@bl-nero bl-nero deleted the bl-nero/field-checkbox branch June 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants