refactor keystore config #43154
Merged
refactor keystore config #43154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
no-changelog
rosstimothy
approved these changes
Jun 18, 2024
| @@ -5687,7 +5687,7 @@ func TestGenerateHostCert(t *testing.T) { | |||
| // the first available identity. | |||
| func TestLocalServiceRolesHavePermissionsForUploaderService(t *testing.T) { | |||
| srv, err := NewTestAuthServer(TestAuthServerConfig{Dir: t.TempDir()}) | |||
| require.NoError(t, err) | |||
| require.NoError(t, err, trace.DebugReport(err)) | |||
There was a problem hiding this comment.
Is this something left over from debugging a failed test?
There was a problem hiding this comment.
yes but I don't think it's worth reverting, it was helpful for me 🤷
codingllama
reviewed
Jun 18, 2024
codingllama
approved these changes
Jun 18, 2024
public-teleport-github-review-bot
bot
removed the request for review
from gzdunek
nklaassen
force-pushed
the
nklaassen/keystore-config2
branch
from
f300440 to
8f0b329
Compare
I wrote all this originally and Tim's the only other person who has touched it |
codingllama
approved these changes
Jun 18, 2024
lib/service/servicecfg/auth.go
Outdated
Comment on lines
257
to
258
| GCPKMSProtectionLevelHSM = "HSM" | ||
| GCPKMSProtectionLevelSoftware = "SOFTWARE" |
|
@nklaassen See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently duplicated most fields of
(lib/auth/keystore).Configtypes to(lib/service/servicecfg).KeystoreConfigto break some dependencies on cloud SDKs in our client binaries.This PR deletes
(lib/auth/keystore).Configto unify on(lib/service/servicecfg).KeystoreConfig. It adds a newkeystore.Optionsstruct to hold runtime options for the keystore, in contrast toKeystoreConfigwhich holds mostly static options coming from the config file.No functional changes are made here.
Depends on #43153 and https://github.com/gravitational/teleport.e/pull/4425
I made these changes while prepping the keystore to support configurable signature algorithms for the implementation of RFD 136.