-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump styled-system and @types/styled-system #43089
Conversation
6667ee4
to
3bc9f53
Compare
e7a9759
to
5f62419
Compare
7ed3f51
to
cdf8fe0
Compare
5ea8530
to
d514c40
Compare
Bumps [styled-components](https://github.com/styled-components/styled-components) from 5.3.11 to 6.1.11. - [Release notes](https://github.com/styled-components/styled-components/releases) - [Commits](styled-components/styled-components@v5.3.11...v6.1.11) --- updated-dependencies: - dependency-name: styled-components dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [styled-system](https://github.com/jxnblk/styled-system) and [@types/styled-system](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/styled-system). These dependencies needed to be updated together. Updates `styled-system` from 3.2.1 to 5.1.5 - [Release notes](https://github.com/jxnblk/styled-system/releases) - [Changelog](https://github.com/styled-system/styled-system/blob/master/CHANGELOG.md) - [Commits](styled-system/styled-system@v3.2.1...v5.1.5) Updates `@types/styled-system` from 3.2.2 to 5.1.22 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/styled-system) --- updated-dependencies: - dependency-name: styled-system dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/styled-system" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
d514c40
to
9dab3ff
Compare
9dab3ff
to
f3a7af5
Compare
All problems fixed, this PR is now ready for review. It's recommended to review it commit by commit. Summary of changes:
|
Accompanying Enterprise change: https://github.com/gravitational/teleport.e/pull/4617 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
poked around a little in the web UI lgtm
MaxHeightProps, | ||
AlignSelfProps { | ||
alt?: string; | ||
style?: React.CSSProperties; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is style
required to do something like this?
<Image style={{css}} />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We might avoid listing these properties separately, and instead use the construct that basically says "all allowed attributes of Image element", but I encountered some problems there, and decided it's not worth generalizing if right now, we only use these two.
e03e9a5
to
9c33c7d
Compare
Bumps styled-system and @types/styled-system. These dependencies needed to be updated together.
Updates
styled-system
from 3.2.1 to 5.1.5Release notes
Sourced from styled-system's releases.
Changelog
Sourced from styled-system's changelog.
... (truncated)
Commits
629fa1a
v5.1.5d5ed7c6
Edit changelog50fcdad
Merge pull request #1137 from RyanTheAllmighty/fix-responsive-null-stylingd8d2483
Merge pull request #1139 from styled-system/dependabot/npm_and_yarn/react-scr...841d2c2
Merge pull request #1144 from styled-system/dependabot/npm_and_yarn/rollup-1....9750f76
Merge pull request #1143 from styled-system/dependabot/npm_and_yarn/gatsby-pl...62c231b
Merge pull request #1141 from styled-system/dependabot/npm_and_yarn/gatsby-2....1ea4ca7
Merge pull request #1142 from styled-system/dependabot/npm_and_yarn/husky-4.2.34ee3c01
Bump rollup from 1.31.0 to 1.31.12b722a6
Bump gatsby-plugin-mdx from 1.0.70 to 1.0.73Updates
@types/styled-system
from 3.2.2 to 5.1.22Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)