Fix setting request reason for automatic ssh access requests. #43076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/sm
tsh
zmb3
approved these changes
Jun 17, 2024
atburke
approved these changes
Jun 17, 2024
public-teleport-github-review-bot
bot
removed the request for review
from nklaassen
nklaassen
approved these changes
Jun 17, 2024
|
@zmb3 can I get excludeflake for this? |
|
/excludeflake TestSSHAccessRequest |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AntonAM
added a commit
that referenced
this pull request
Jun 18, 2024
* Fix setting request reason for automatic ssh access requests. * Use slices.ContainsFunc for test check.
This was referenced Jun 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
#43180) * Fix setting request reason for automatic ssh access requests. * Use slices.ContainsFunc for test check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that after adding automatic role access requests ( #39003 ) , request reason functionality got broken - in tsh codepath we never set reason for resource requests and only set reason for role requests if there's more than one role. This PR fixes that, so we again get request reason from the flag or prompt user for it.
I also added tsh logout/login in the tests, I think second test case didn't actually work because we had approved access request from the first one.
Changelog: Fix setting request reason for automatic ssh access requests.
Fixes #42634