-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to disable unqualified hostname lookups #42952
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
added
backport/branch/v14
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v15
backport/branch/v16
labels
Jun 13, 2024
fspmarshall
force-pushed
the
fspmarshall/unqualified-hostname-lookups
branch
from
June 14, 2024 03:36
1e9e903
to
579eb2c
Compare
espadolini
approved these changes
Jun 14, 2024
rosstimothy
approved these changes
Jun 14, 2024
public-teleport-github-review-bot
bot
removed request for
codingllama and
atburke
June 14, 2024 15:44
fspmarshall
force-pushed
the
fspmarshall/unqualified-hostname-lookups
branch
from
June 14, 2024 16:18
579eb2c
to
4ec9e37
Compare
espadolini
reviewed
Jun 14, 2024
fspmarshall
force-pushed
the
fspmarshall/unqualified-hostname-lookups
branch
from
June 14, 2024 17:13
4ec9e37
to
fe1b30a
Compare
rosstimothy
approved these changes
Jun 14, 2024
@fspmarshall See the table below for backport results.
|
This was referenced Jun 20, 2024
fspmarshall
added a commit
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v14
backport/branch/v15
backport/branch/v16
no-changelog
Indicates that a PR does not require a changelog entry
size/sm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to disable unqualified hostname lookups via
TELEPORT_UNSTABLE_DISABLE_UNQUALIFIED_LOOKUPS=yes
. Depending on the configuration and usage of a teleport cluster, some teleport clusters produce a massive amount of ineffectual DNS lookups for unqualified hostnames (mostly server IDs). This can become problematic for very large clusters experiencing very high usage.