Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to disable unqualified hostname lookups #42952

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

fspmarshall
Copy link
Contributor

Adds the ability to disable unqualified hostname lookups via TELEPORT_UNSTABLE_DISABLE_UNQUALIFIED_LOOKUPS=yes. Depending on the configuration and usage of a teleport cluster, some teleport clusters produce a massive amount of ineffectual DNS lookups for unqualified hostnames (mostly server IDs). This can become problematic for very large clusters experiencing very high usage.

@fspmarshall fspmarshall added backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 labels Jun 13, 2024
@github-actions github-actions bot requested review from atburke and codingllama June 13, 2024 22:44
@fspmarshall fspmarshall force-pushed the fspmarshall/unqualified-hostname-lookups branch from 1e9e903 to 579eb2c Compare June 14, 2024 03:36
lib/proxy/router.go Outdated Show resolved Hide resolved
@fspmarshall fspmarshall force-pushed the fspmarshall/unqualified-hostname-lookups branch from 579eb2c to 4ec9e37 Compare June 14, 2024 16:18
lib/auth/auth_with_roles.go Outdated Show resolved Hide resolved
lib/proxy/router.go Outdated Show resolved Hide resolved
@fspmarshall fspmarshall force-pushed the fspmarshall/unqualified-hostname-lookups branch from 4ec9e37 to fe1b30a Compare June 14, 2024 17:13
@fspmarshall fspmarshall enabled auto-merge June 14, 2024 17:14
@fspmarshall fspmarshall added this pull request to the merge queue Jun 20, 2024
Merged via the queue into master with commit c653a84 Jun 20, 2024
39 checks passed
@fspmarshall fspmarshall deleted the fspmarshall/unqualified-hostname-lookups branch June 20, 2024 20:38
@public-teleport-github-review-bot

@fspmarshall See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants