Add tests for AMR notification routing for discord plugin #42920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
marcoandredinis
approved these changes
Jun 14, 2024
tigrato
reviewed
Jun 14, 2024
Adding in some test coverage at the moment. |
tigrato
approved these changes
Jun 19, 2024
r0mant
reviewed
Jul 1, 2024
Waiting on #43714 being merged first so we dont' run into another case of the AMR watcher failing to start and preventing plugins working for people who aren't using it. |
EdwardDowling
force-pushed
the
edwarddowling/discord-plugin-amr
branch
from
91786be to
36a06c7
Compare
EdwardDowling
force-pushed
the
edwarddowling/discord-plugin-amr
branch
from
60d7092 to
f5a6306
Compare
EdwardDowling
changed the title
EdwardDowling
added
no-changelog
|
Changes made in refactor here means the explicit enabling of Discord is no longer needed. Going to only add the tests in this PR |
|
@marcoandredinis Can you take another look at this when you get a chance? |
marcoandredinis
approved these changes
Aug 22, 2024
tigrato
approved these changes
Aug 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@EdwardDowling See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of 42856