Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes DocumentNodes.story.tsx #42788

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

ibeckermayer
Copy link
Contributor

Fixes #41401

These storybooks had not been kept up to date with changing underlying shapes, thus all the DocumentNodes stories were in an error state. This fixes that, and eliminates the multiple ways to call fetchNodes/fetchClusters which was the key to why typescript didn't alert of this sooner.

@ibeckermayer ibeckermayer enabled auto-merge June 11, 2024 18:25
Merged via the queue into master with commit 1e1a625 Jun 11, 2024
39 checks passed
@ibeckermayer ibeckermayer deleted the isaiah/fix-DocumentNodes-storytest branch June 11, 2024 18:38
@public-teleport-github-review-bot

@ibeckermayer See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Failed
branch/v16 Create PR

ibeckermayer pushed a commit that referenced this pull request Jun 11, 2024
* Fixes DocumentNodes.story.tsx and corresponding test (hopefully)

* eliminate fetchNodes and fetchClusters in favor of calling services directly
github-merge-queue bot pushed a commit that referenced this pull request Jun 12, 2024
* Fixes DocumentNodes.story.tsx and corresponding test (hopefully)

* eliminate fetchNodes and fetchClusters in favor of calling services directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocumentNodes.story.test.tsx flakiness
4 participants