Web: export decodeUrlQueryParam function #42597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlisa
added
backport/branch/v14
no-changelog
avatus
approved these changes
Jun 7, 2024
gzdunek
approved these changes
Jun 10, 2024
| @@ -90,7 +90,7 @@ export default function useServersideSearchPanel({ | |||
| }; | |||
| } | |||
|
|
|||
| function decodeUrlQueryParam(param: string) { | |||
| export function decodeUrlQueryParam(param: string) { | |||
There was a problem hiding this comment.
If we want to export this function, I think that we should find a better place for it.
The e code that is going to relay on this function doesn't use the serverside search panel, so I think it's better to export it from a more generic place.
I'm thinking about web/packages/teleport/src/components/hooks/useUrlFiltering/decodeUrlQueryParam.ts (and then re-export from its index.ts).
Then I'd add a proper JSDoc comment to it.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.