Make access request notifications expire alongside the access request #42527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
no-changelog
rudream
requested review from
avatus and
kimlisa
and removed request for
codingllama and
greedy52
avatus
approved these changes
Jun 6, 2024
greedy52
approved these changes
Jun 6, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kimlisa
rudream
force-pushed
the
yassine/notifications/access-request-expiry
branch
from
2790b6c to
d90aa70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR sets the expiry date of access request notifications to be the same as the expiry of the access request itself. This is to prevent the odd UX in the WebUI where clicking a notification for an expired access request will take you to a page with an "access request not found" error.
Also prevents expired notifications from being returned when fetching notifications. This is to handle the cases where a notification has expired but has not yet been deleted by the periodic cleanup.