Add --invite and --reason to tsh ssh #42325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
kubernetes-access
rfd
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
github-actions
bot
requested review from
fheinecke,
nklaassen,
ptgott,
r0mant and
xinding33
zmb3
added
backport/branch/v14
no-changelog
zmb3
force-pushed
the
zmb3/remove-moderated-session-invite
branch
from
a73162f to
54f26f2
Compare
|
🤖 Vercel preview here: https://docs-omcwt5pxt-goteleport.vercel.app/docs/ver/preview |
ptgott
approved these changes
Jun 3, 2024
| Note that you can share terminal sessions using any Teleport edition. However, you must | ||
| have Teleport Enterprise or Teleport Enterprise Cloud if you want to require active | ||
| Note that you can share terminal sessions using any Teleport edition. However, you must | ||
| have Teleport Enterprise or Teleport Enterprise Cloud if you want to require active |
There was a problem hiding this comment.
Suggested change
| have Teleport Enterprise or Teleport Enterprise Cloud if you want to require active | |
| have Teleport Enterprise if you want to require active |
Fixing linter warning
|
🤖 Vercel preview here: https://docs-2lr9ukxg8-goteleport.vercel.app/docs/ver/preview |
zmb3
force-pushed
the
zmb3/remove-moderated-session-invite
branch
from
54f26f2 to
867f950
Compare
|
🤖 Vercel preview here: https://docs-4sh58dll9-goteleport.vercel.app/docs/ver/preview |
zmb3
changed the title
russjones
approved these changes
Jun 3, 2024
These flags are part of the moderated sessions feature and are used to update the session tracker resource. As mentioned in the RFD, they were supposed to be added to `tsh kube exec` and `tsh ssh`. While `tsh kube exec` works as intended, for SSH we mistakenly added these flags to `tsh join`. As a result, these flags were effectively no-ops for SSH sessions. Additionally, the environment variable used to propagate session invite information was incorrect named "JOIN_MODE" presumably due to a copy-paste error. This has been fixed, but we will continue to check the old env var for 1 major release to maintain backwards compatibility. Closes #42255
zmb3
force-pushed
the
zmb3/remove-moderated-session-invite
branch
from
867f950 to
7f3367e
Compare
|
🤖 Vercel preview here: https://docs-ntlszu65t-goteleport.vercel.app/docs/ver/preview |
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move --reason and --invite to tsh ssh
These flags are part of the moderated sessions feature and are
used to update the session tracker resource. As mentioned in the
RFD, they were supposed to be added to
tsh kube execandtsh ssh.While
tsh kube execworks as intended, for SSH we mistakenly addedthese flags to
tsh join. As a result, these flags were effectivelyno-ops for SSH sessions.
Additionally, the environment variable used to propagate session
invite information was incorrect named "JOIN_MODE" presumably due
to a copy-paste error. This has been fixed, but we will continue
to check the old env var for 1 major release to maintain backwards
compatibility.
Closes #42255