Restrict cipher suites for Desktop Access in FIPS mode #42277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hash is on a branch and should be changed once that branch is merged. It includes the `set_fips_compliance_policy` function which is used to enforce FIPS-valid ciphers in the connection. This commit also updates `Cargo.lock` generally by having called `cargo update` before committing the changes.
probakowski
approved these changes
Jun 3, 2024
ibeckermayer
requested review from
camscale and
r0mant
and removed request for
EdwardDowling
zmb3
approved these changes
Jun 3, 2024
Co-authored-by: Zac Bergquist <[email protected]>
|
I've added this note to the documentation re: Desktop Access FIPS: ab64baa |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
🤖 Vercel preview here: https://docs-8107z7e87-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-j29wuxett-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-kvy7f9kqo-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-e9nq1972y-goteleport.vercel.app/docs/ver/preview |
zmb3
reviewed
Jun 12, 2024
Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Zac Bergquist <[email protected]>
Co-authored-by: Zac Bergquist <[email protected]>
|
🤖 Vercel preview here: https://docs-mrhfdecv1-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-hpn5owylz-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-g7bqvdmld-goteleport.vercel.app/docs/ver/preview |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@ibeckermayer See the table below for backport results.
|
ibeckermayer
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Updates to the new boring fork's hash with FIPS enforcement. This hash is on a branch and should be changed once that branch is merged. It includes the `set_fips_compliance_policy` function which is used to enforce FIPS-valid ciphers in the connection. This commit also updates `Cargo.lock` generally by having called `cargo update` before committing the changes. * reverts previous changes such that we are again using clang 12.0.0 rather than 14.0.6 * Updates to latest boring hash * removes rdp client for fips builds on arm64 * updates e to isaiah/enforce-fips head * Updates boring ref * Updates boring ref * Update Makefile Co-authored-by: Zac Bergquist <[email protected]> * Adds note about desktop access fips to fedramp docs * Updates boring hash to now-merged HEAD of the `teleport` branch * update e to latest head * try adding --nocheck to see if that fixes arm64 builds * udates to latest HEAD * latest e * Update docs/pages/access-controls/compliance-frameworks/fedramp.mdx Co-authored-by: Zac Bergquist <[email protected]> * Update docs/pages/access-controls/compliance-frameworks/fedramp.mdx Co-authored-by: Zac Bergquist <[email protected]> * Update docs/pages/access-controls/compliance-frameworks/fedramp.mdx Co-authored-by: Zac Bergquist <[email protected]> * noteable --> notable --------- Co-authored-by: Zac Bergquist <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
* Updates to the new boring fork's hash with FIPS enforcement. This hash is on a branch and should be changed once that branch is merged. It includes the `set_fips_compliance_policy` function which is used to enforce FIPS-valid ciphers in the connection. This commit also updates `Cargo.lock` generally by having called `cargo update` before committing the changes. * reverts previous changes such that we are again using clang 12.0.0 rather than 14.0.6 * Updates to latest boring hash * removes rdp client for fips builds on arm64 * updates e to isaiah/enforce-fips head * Updates boring ref * Updates boring ref * Update Makefile * Adds note about desktop access fips to fedramp docs * Updates boring hash to now-merged HEAD of the `teleport` branch * update e to latest head * try adding --nocheck to see if that fixes arm64 builds * udates to latest HEAD * latest e * Update docs/pages/access-controls/compliance-frameworks/fedramp.mdx * Update docs/pages/access-controls/compliance-frameworks/fedramp.mdx * Update docs/pages/access-controls/compliance-frameworks/fedramp.mdx * noteable --> notable --------- Co-authored-by: Zac Bergquist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the boring hash in the Cargo.toml to one which allows us to call
builder.set_fips_compliance_policy()?;, which restricts cipher suites to those which are FIPS validated. To this end, it also reverts clang from 14 to 12.0.0 in the buildbox, because the boring hash we're now using is using a (actually, not soon-to-be) FIPS-validated hash for boringssl which must be built by 12.0.0.It also removes the RDP client (and therefore Desktop Access feature) for FIPS builds on arm64. It was proving extremely difficult to get boringssl to build via the Centos 7 Docker image. Since we are unaware of paying customers who require running a FIPS-enabled Windows Desktop Service on this architecture, we've elected to just drop support for now.
Closes https://github.com/gravitational/teleport.e/issues/3065
Closes https://github.com/gravitational/customer-sensitive-requests/issues/254
Depends on
set_fips_compliance_policy(FIPS enforcement mechanism) boring#9