fix app keepalive #42240
Merged
fix app keepalive #42240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
rosstimothy
reviewed
May 31, 2024
fspmarshall
force-pushed
the
fspmarshall/fix-app-keepalive
branch
from
64de56a to
0bfaaa5
Compare
rosstimothy
approved these changes
May 31, 2024
tigrato
approved these changes
Jun 1, 2024
|
@fspmarshall See the table below for backport results.
|
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where individual app keepalives failures would kill the GRPC stream over which all apps were being heartbeat.
There is at least one case (when an agent decides to stop serving a given app), where keepalives are expected/supposed to fail. Additionally, keepalives are a nice-to-have feature rather than something critical for teleport function. Rather than try to only suppress failure in the expected case (which can be a bit tricky to distinguish from an unexpected failure), we this change just always stops keep alive attempts for a given app if we hit multiple consecutive failures. This keeps the overall logic simple, and doesn't have much of a downside since a spurious stop will get fixed at the next heartbeat anyway.
changelog: fixed an issue where removing an app could make teleport app agents incorrectly report as unhealthy for a short time.