Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log cluster rename message at error level, not warn #42208

Merged
merged 1 commit into from
May 31, 2024
Merged

Log cluster rename message at error level, not warn #42208

merged 1 commit into from
May 31, 2024

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented May 30, 2024

Closes #42153

@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

espadolini
espadolini approved these changes May 31, 2024
View reviewed changes
lib/auth/init.go Outdated Show resolved Hide resolved
lib/auth/init.go Outdated Show resolved Hide resolved
@espadolini espadolini added the no-changelog Indicates that a PR does not require a changelog entry label May 31, 2024
@zmb3 zmb3 enabled auto-merge May 31, 2024 14:19
@zmb3 zmb3 force-pushed the zmb3/rename-error branch from 1212a13 to 5622165 Compare May 31, 2024 16:49
@zmb3 zmb3 added this pull request to the merge queue May 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 31, 2024
@zmb3 zmb3 added this pull request to the merge queue May 31, 2024
Merged via the queue into master with commit a64f5b8 May 31, 2024
37 checks passed
@zmb3 zmb3 deleted the zmb3/rename-error branch May 31, 2024 17:50
@public-teleport-github-review-bot
Copy link

@zmb3 See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR
branch/v16 Create PR

This was referenced May 31, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielcorado gabrielcorado gabrielcorado approved these changes

@espadolini espadolini espadolini approved these changes

Assignees
No one assigned
Labels
backport/branch/v14 backport/branch/v15 backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit a ERROR not a WARN when cluster name change is detected
3 participants
@zmb3 @espadolini @gabrielcorado