Set default availability mode to ALL #42200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avatus
added
backport-required
no-changelog
Rather than letting the default mode be UNSPECIFIED, this sets the default mode to "ALL". Note: this does not mean that a user can see all by default. It only reflects the "Availability filter" selection. If a cluster has showResources set to "accessible_only", the filter will reflect that value instead
avatus
force-pushed
the
avatus/default_avail
branch
from
d6017c4 to
5a4fccd
Compare
rudream
approved these changes
May 31, 2024
kimlisa
approved these changes
May 31, 2024
public-teleport-github-review-bot
bot
removed request for
espadolini and
gabrielcorado
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
avatus
added a commit
that referenced
this pull request
Jun 3, 2024
This commit will "invalidate" #42200 as it now defaults to NONE instead of ALL. This will allow us to change the visual of the included resource filter. NONE and ALL still function the same from a backend perspective, and will return the same resources. But now, if NONE is selected, the filter shows nothing checked and if ALL is selected, all the options are checked and the filter indicator is present
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
This commit will "invalidate" #42200 as it now defaults to NONE instead of ALL. This will allow us to change the visual of the included resource filter. NONE and ALL still function the same from a backend perspective, and will return the same resources. But now, if NONE is selected, the filter shows nothing checked and if ALL is selected, all the options are checked and the filter indicator is present
github-actions bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
This commit will "invalidate" #42200 as it now defaults to NONE instead of ALL. This will allow us to change the visual of the included resource filter. NONE and ALL still function the same from a backend perspective, and will return the same resources. But now, if NONE is selected, the filter shows nothing checked and if ALL is selected, all the options are checked and the filter indicator is present
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
This commit will "invalidate" #42200 as it now defaults to NONE instead of ALL. This will allow us to change the visual of the included resource filter. NONE and ALL still function the same from a backend perspective, and will return the same resources. But now, if NONE is selected, the filter shows nothing checked and if ALL is selected, all the options are checked and the filter indicator is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than letting the default mode be UNSPECIFIED, this sets the default mode to "ALL".
Note: this does not mean that a user can see all by default. It only reflects the "Availability filter" selection. If a cluster has showResources set to "accessible_only", the filter will reflect that value instead