Add tctl notifications commands
#42124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
no-changelog
rosstimothy
reviewed
May 29, 2024
zmb3
reviewed
May 29, 2024
api/proto/teleport/notifications/v1/notifications_service.proto
Outdated
Show resolved
Hide resolved
rudream
force-pushed
the
yassine/notifications/tctl
branch
3 times, most recently
from
31c6f2f to
2bf04aa
Compare
rosstimothy
reviewed
Jun 27, 2024
api/proto/teleport/notifications/v1/notifications_service.proto
Outdated
Show resolved
Hide resolved
api/proto/teleport/notifications/v1/notifications_service.proto
Outdated
Show resolved
Hide resolved
api/proto/teleport/notifications/v1/notifications_service.proto
Outdated
Show resolved
Hide resolved
rosstimothy
reviewed
Jul 12, 2024
api/proto/teleport/notifications/v1/notifications_service.proto
Outdated
Show resolved
Hide resolved
zmb3
reviewed
Jul 22, 2024
api/proto/teleport/notifications/v1/notifications_service.proto
Outdated
Show resolved
Hide resolved
rudream
force-pushed
the
yassine/notifications/tctl
branch
from
01db620 to
73875a2
Compare
zmb3
approved these changes
Jul 23, 2024
rosstimothy
reviewed
Jul 25, 2024
api/proto/teleport/notifications/v1/notifications_service.proto
Outdated
Show resolved
Hide resolved
api/proto/teleport/notifications/v1/notifications_service.proto
Outdated
Show resolved
Hide resolved
rudream
force-pushed
the
yassine/notifications/tctl
branch
from
73875a2 to
2ad4697
Compare
rosstimothy
approved these changes
Jul 29, 2024
rudream
force-pushed
the
yassine/notifications/tctl
branch
from
2ad4697 to
3d15338
Compare
rudream
force-pushed
the
yassine/notifications/tctl
branch
2 times, most recently
from
a6d3f16 to
d560e0e
Compare
zmb3
approved these changes
Aug 7, 2024
|
/excludeflake TestNotificationCommmandCRUD |
rudream
force-pushed
the
yassine/notifications/tctl
branch
from
d560e0e to
8737ecb
Compare
zmb3
removed
the
no-changelog
rudream
force-pushed
the
yassine/notifications/tctl
branch
from
8737ecb to
042816a
Compare
rudream
added a commit
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #37704
This PR adds various
tctlcommands for creating and managing user-created notifications.Admins can create notifications targeting one or more roles, or target a specific user. They can also list user-created user-specific notifications for a user, or user-created global notifications.
changelog: tctl allows cluster administrators to create custom notifications targeting Teleport users.