Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document EKS Auto discovery self-bootstrap #42107

Merged
merged 7 commits into from
May 30, 2024
Merged

docs: document EKS Auto discovery self-bootstrap #42107

merged 7 commits into from
May 30, 2024

Conversation

tigrato
Copy link
Contributor

@tigrato tigrato commented May 28, 2024 •
edited
Loading

This PR documents EKS auto-discovery self bootstrap using AccessEntries to gain access to the cluster.

Docs for #41693

@tigrato tigrato added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 labels May 28, 2024
@tigrato
docs: document EKS Auto discovery self-bootstrap
260be7a 
This PR documents EKS auto-discovery self bootstrap using AccessEntries
to gain access to the cluster.

Signed-off-by: Tiago Silva <[email protected]>
@tigrato tigrato force-pushed the tigrato/kube-auto-discovery-docs branch from 4858965 to 260be7a Compare May 28, 2024 20:02
@tigrato tigrato marked this pull request as ready for review May 28, 2024 20:04
@github-actions github-actions bot requested review from ptgott, r0mant, xinding33 and zmb3 May 28, 2024 20:04
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-g4vxyx1n7-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-cd0lnwx6g-goteleport.vercel.app/docs/ver/preview

@tigrato @stevenGravy
Update kubernetes.mdx
1e933eb 
Co-authored-by: Steven Martin <[email protected]>
@tigrato @stevenGravy
Update kubernetes.mdx
e484d04 
Co-authored-by: Steven Martin <[email protected]>
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-27dz0ayy5-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-osay5sr17-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-l5n0qmumw-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-mv7r3rurx-goteleport.vercel.app/docs/ver/preview

ptgott
ptgott reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a partial review of everything besides the docs/pages/auto-discovery/kubernetes/aws.mdx guide.

docs/pages/auto-discovery/kubernetes.mdx Outdated Show resolved Hide resolved
docs/pages/auto-discovery/kubernetes.mdx Outdated Show resolved Hide resolved
docs/pages/auto-discovery/kubernetes.mdx Outdated Show resolved Hide resolved
docs/pages/auto-discovery/kubernetes.mdx Outdated
the Teleport Discovery Service. The monitoring process involves a label
matching mechanism to identify and manage the EKS clusters.

1. **Discovery and Label Matching**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is a little difficult for me to read. Would it be possible to use subheadings in place of the numbered list items and regular body text instead of the bulleted list items? Since these are full sentences, I don't think bullets make them more readable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this? I tried to split them in operations that would make sense

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a suggestion!

docs/pages/auto-discovery/kubernetes.mdx Show resolved Hide resolved
@tigrato tigrato requested a review from ptgott May 29, 2024 22:18
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-f0xh41h0u-goteleport.vercel.app/docs/ver/preview

ptgott
ptgott approved these changes May 30, 2024
View reviewed changes
docs/pages/auto-discovery/kubernetes.mdx Outdated Show resolved Hide resolved
@tigrato @ptgott
Update kubernetes.mdx
3dc08dd 
Co-authored-by: Paul Gottschling <[email protected]>
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-jsh95th3m-goteleport.vercel.app/docs/ver/preview

@tigrato tigrato added this pull request to the merge queue May 30, 2024
Merged via the queue into master with commit d86c25e May 30, 2024
38 checks passed
@tigrato tigrato deleted the tigrato/kube-auto-discovery-docs branch May 30, 2024 21:35
@public-teleport-github-review-bot
Copy link

@tigrato See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR

This was referenced May 30, 2024
Merged
Merged
@tigrato tigrato mentioned this pull request Aug 28, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenGravy stevenGravy stevenGravy approved these changes

@ptgott ptgott ptgott approved these changes

@r0mant r0mant Awaiting requested review from r0mant

@xinding33 xinding33 Awaiting requested review from xinding33

@zmb3 zmb3 Awaiting requested review from zmb3

Assignees
No one assigned
Labels
backport/branch/v15 backport/branch/v16 documentation no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tigrato @ptgott @stevenGravy