Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14] Reduce tsh binary size #41976

Merged
merged 1 commit into from
May 24, 2024
Merged

[v14] Reduce tsh binary size #41976

merged 1 commit into from
May 24, 2024

Conversation

rosstimothy
Copy link
Contributor

@rosstimothy rosstimothy commented May 23, 2024 •
edited
Loading

Backport #41743 to branch/v14

A local build compared to branch/v14:

ls -lah ~/src/teleport/build/
total 1309984
drwxr-xr-x@  7 tim  staff   224B May 24 10:26 ./
drwxr-xr-x@ 80 tim  staff   2.5K May 24 10:26 ../
-rwxr-xr-x@  1 tim  staff   111M May 24 10:26 tsh-branch/v14*
-rwxr-xr-x@  1 tim  staff    97M May 24 10:25 tsh-backport-41743/v14*

@rosstimothy rosstimothy added backport no-changelog Indicates that a PR does not require a changelog entry labels May 23, 2024
@rosstimothy rosstimothy force-pushed the tross/backport-41743/v14 branch from b1c551c to 0673558 Compare May 23, 2024 20:35
@rosstimothy
Reduce tsh binary size (#41743)
ff665c8 
* Remove lib/web dependency from tsh

Refactors the terminal stream code in lib/web into a subpackage
so that tsh no longer depends on the entire lib/web package.

* Remove lib/auth dependency from tsh

Refactors invalid credentials errors and helpers into lib/auth/authclient
so that tsh no longer imports lib/auth directly.

* fix find-replace typos
@rosstimothy rosstimothy force-pushed the tross/backport-41743/v14 branch from 0673558 to ff665c8 Compare May 24, 2024 13:59
@rosstimothy rosstimothy marked this pull request as ready for review May 24, 2024 14:28
@github-actions github-actions bot added desktop-access size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels May 24, 2024
@github-actions github-actions bot requested review from probakowski and zmb3 May 24, 2024 14:29
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from probakowski May 24, 2024 20:21
@rosstimothy rosstimothy enabled auto-merge May 24, 2024 20:21
@rosstimothy rosstimothy added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@rosstimothy rosstimothy added this pull request to the merge queue May 24, 2024
Merged via the queue into branch/v14 with commit 25497b9 May 24, 2024
34 of 35 checks passed
@rosstimothy rosstimothy deleted the tross/backport-41743/v14 branch May 24, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmb3 zmb3 zmb3 approved these changes

@marcoandredinis marcoandredinis marcoandredinis approved these changes

Assignees
No one assigned
Labels
backport desktop-access no-changelog Indicates that a PR does not require a changelog entry size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosstimothy @marcoandredinis @zmb3