Add access list notifications support to new notifications list #41662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
the
no-changelog
avatus
reviewed
May 16, 2024
avatus
approved these changes
May 20, 2024
kimlisa
reviewed
May 20, 2024
rudream
force-pushed
the
yassine/notifications/access-requests
branch
2 times, most recently
from
cba98ac to
6605d07
Compare
rudream
force-pushed
the
yassine/notifications/access-lists
branch
from
b0e6ebe to
15a13b6
Compare
rudream
force-pushed
the
yassine/notifications/access-requests
branch
from
6605d07 to
1f53170
Compare
rudream
force-pushed
the
yassine/notifications/access-lists
branch
from
15a13b6 to
f425c2b
Compare
|
@avatus @kimlisa FYI this now as an |
rudream
force-pushed
the
yassine/notifications/access-lists
branch
from
f425c2b to
8df84fc
Compare
rudream
force-pushed
the
yassine/notifications/access-lists
branch
from
8df84fc to
6c9e501
Compare
kimlisa
reviewed
May 31, 2024
kimlisa
approved these changes
Jun 4, 2024
rudream
force-pushed
the
yassine/notifications/access-lists
branch
from
233c795 to
a5f51e8
Compare
rudream
force-pushed
the
yassine/notifications/access-lists
branch
from
a5f51e8 to
54b1b4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #37704
ecounterpart: https://github.com/gravitational/teleport.e/pull/4221This PR adds access list notifications support to the new notifications list in the WebUI.
Implementation
The frontend currently supports access list notifications by fetching access lists on init, and then running some logic to determine whether any of them need to be reviewed soon, and then if so, creating client-side notifications and adding them to a
notificationsStorewhich the topbar notifications pane reads from.With the new notifications system, notifications are generated and stored in the backend, but this isn't feasible for access list notifications because the system doesn't support scheduling notifications for a specific time. The workaround implemented in this PR uses the existing frontend method for showing access list notifications, and adapts it to the new notifications list.
When "real" notifications are fetched from the backend and shown in the UI list, the notifications component will also read from the
notificationsStoreand prepend any access list notifications to the final list of notifications. This only ever needs to be done on the first fetch.It is also possible to mark these access list notifications as clicked or hide them, as is the behaviour for the other "real" notifications, these states are kept in
localStorage.This PR also includes some improvements to the way updating notification states is done in the frontend.
Demo
access.list.notifications.mov