Web: create JS version of parsing string with double quotes delimited by commas #41086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
kimlisa
added
no-changelog
zmb3
approved these changes
May 1, 2024
avatus
approved these changes
May 1, 2024
Comment on lines
+53
to
+56
| // Replaces all beginning and trailing spaces and quotes. | ||
| const regex = /^[" ]+|[" ]+$/g; | ||
| tokens.push(str.substring(tokenStart, i).replace(regex, '')); | ||
| tokenStart = i + 1; |
There was a problem hiding this comment.
Suggested change
| // Replaces all beginning and trailing spaces and quotes. | |
| const regex = /^[" ]+|[" ]+$/g; | |
| tokens.push(str.substring(tokenStart, i).replace(regex, '')); | |
| tokenStart = i + 1; | |
| // Replaces all beginning and trailing spaces and quotes. | |
| tokens.push(str.substring(tokenStart, i).trim().replace('"', '')); | |
| tokenStart = i + 1; |
can we use trim and then just replace the quotes? would be easier than a regex imo. Up to you
There was a problem hiding this comment.
the regex does: only replace quotes from start and end (not in between), and handles spaces before and after quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of https://github.com/gravitational/teleport.e/issues/3933
I needed a way to parse string with quotes delimited by comma
"access", "editor", "admin", so i took the backend version of ParseSearchKeywords and turned it into the JS version.