Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v15] Add new flags to modules to replace isTeam (#39695) #41066

Merged
merged 2 commits into from
May 2, 2024

Conversation

mcbattirola
Copy link
Contributor

Backports #39695 to v15

* Add new flags to modules

* Add deprecated comments to isTeam

* Make support flag an enum

* Add a TODO instead of deprecating flag right away

Co-authored-by: Alan Parra <[email protected]>

* Add gogoproto.jsontag to new fields

* remove meaning from enum zero value

* Reuse proto.SupportType instead of suping

* Update proto file: rename enum 0 value to unspecified;fix json tag casing

* Reuse proto file instead of aliasing it

---------

Co-authored-by: Alan Parra <[email protected]>
@mcbattirola mcbattirola marked this pull request as ready for review April 30, 2024 19:03
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@mcbattirola mcbattirola added the no-changelog Indicates that a PR does not require a changelog entry label Apr 30, 2024
@mcbattirola mcbattirola enabled auto-merge May 2, 2024 11:40
@mcbattirola mcbattirola added this pull request to the merge queue May 2, 2024
Merged via the queue into branch/v15 with commit d73b7e9 May 2, 2024
39 checks passed
@mcbattirola mcbattirola deleted the mcbattirola/v15/remove-team--new-flags branch May 2, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants