Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community edition license for Teleport 16+ #41054

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Apr 30, 2024

See https://goteleport.com/blog/teleport-community-license/ for details of this announcement.

@zmb3 zmb3 requested a review from klizhentas April 30, 2024 16:07
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions github-actions bot requested review from rosstimothy and tcsc April 30, 2024 16:08
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @fheinecke @camscale this is the file that we should distribute in the tarballs and deb/rpm packages for OSS starting with Teleport 16.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a license file we'd want to include in the enterprise artifacts for symmetry, or do we just leave it out?

I don't think we include a license file at all in any of the release artifacts. Should we add this license to more than just tarballs and deb/rpm packages? MacOS packages? OCI images, AMIs, whatever we do for WIndows?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we include a license file at all in any of the release artifacts.

We definitely do, in tarballs at least. We also have the license field of debs (and maybe rpms) set.

@zmb3 zmb3 added the no-changelog Indicates that a PR does not require a changelog entry label Apr 30, 2024
@fheinecke
Copy link
Contributor

Shouldn't this have a changelog entry for v16? This is a pretty major change. Are we going to include notice of this with the v16 release in some other way?

@zmb3
Copy link
Collaborator Author

zmb3 commented Apr 30, 2024

Shouldn't this have a changelog entry for v16? This is a pretty major change. Are we going to include notice of this with the v16 release in some other way?

Yes, this is not the kind of item I want to be included as a small bullet-point in an auto-generated changelog. For major releases Roman I collaborate on a Google doc with complete release notes.

(Additionally, the UI in Teleport 16 will make it impossible for users to miss this change)

@zmb3 zmb3 force-pushed the zmb3/v16-license branch from 0d5f081 to ec5a88b Compare April 30, 2024 20:36
@zmb3 zmb3 requested a review from TMG63 April 30, 2024 20:36
Copy link
Contributor

@fheinecke fheinecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - just wanted to make sure that customers are notified.

@zmb3 zmb3 added this pull request to the merge queue May 3, 2024
Merged via the queue into master with commit 1d0c382 May 3, 2024
38 checks passed
@zmb3 zmb3 deleted the zmb3/v16-license branch May 3, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants