Feed the correct next page token to ListAllAccessListsMembers
#41043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a typo when listing all members across all Access Lists because when the number of members is bigger than the default page size (1000), `nextToken` is not empty but we always pass the an empty value to the `ListResources` call. This results in the callers to constantly call `ListAllAccessListMembers` until they run out of memory. Signed-off-by: Tiago Silva <[email protected]>
smallinsky
approved these changes
Apr 30, 2024
avatus
approved these changes
Apr 30, 2024
public-teleport-github-review-bot
bot
removed the request for review
from justinas
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo when listing all members across all Access Lists because when the number of members is bigger than the default page size (200),
nextTokenis not empty but we always pass the an empty value to theListResourcescall. This results in the callers to constantly callListAllAccessListMembersuntil they run out of memory.Changelog: Fix a memory leak caused by incorrectly passing the offset when paginating all Access Lists' members. Memory leak only occurs when there are more than the default pagesize (200) Access Lists.