-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vnet][5] app proxying #41033
Merged
Merged
[vnet][5] app proxying #41033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
the
no-changelog
Indicates that a PR does not require a changelog entry
label
Apr 30, 2024
github-actions
bot
added
size/md
tsh
tsh - Teleport's command line tool for logging into nodes running Teleport.
labels
Apr 30, 2024
nklaassen
force-pushed
the
nklaassen/vnet4
branch
from
April 30, 2024 17:03
b776045
to
d9a3f47
Compare
nklaassen
force-pushed
the
nklaassen/vnet5
branch
from
April 30, 2024 17:04
626ecb5
to
5fcbf3f
Compare
Open
nklaassen
force-pushed
the
nklaassen/vnet5
branch
2 times, most recently
from
May 2, 2024 18:36
96812d1
to
85cee19
Compare
Joerger
reviewed
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a couple comments around the MFA changes.
nklaassen
force-pushed
the
nklaassen/vnet-app-mfa
branch
from
May 3, 2024 20:21
e0d1818
to
bea76e5
Compare
nklaassen
force-pushed
the
nklaassen/vnet4
branch
from
May 24, 2024 16:17
6027504
to
6151a17
Compare
nklaassen
force-pushed
the
nklaassen/vnet5
branch
from
May 24, 2024 16:17
3d5639b
to
4981b8c
Compare
This makes it easier to converting profileName + leafName combos into URIs.
nklaassen
force-pushed
the
nklaassen/vnet5
branch
from
May 24, 2024 18:03
4981b8c
to
f951fc6
Compare
nklaassen
requested review from
rosstimothy
and removed request for
fheinecke,
smallinsky,
AntonAM and
strideynet
May 24, 2024 22:07
rosstimothy
approved these changes
May 28, 2024
@nklaassen See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v16
machine-id
no-changelog
Indicates that a PR does not require a changelog entry
size/md
tsh
tsh - Teleport's command line tool for logging into nodes running Teleport.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the sixth in a series of PRs implementing Teleport VNet RFD. parent
This PR completes an MVP
tsh vnet
implementation - with this PR connections are now forwarded all the way to the Teleport app and VNet is actually usable.All teleport clients are cached, I moved the clientcache out of lib/teleterm to share it with Connect. App certificates are automatically reissued on expiry, with a relogin to the cluster if necessary. Per-session MFA is supported. Cached cluster clients will be evicted after a relogin.
This includes the implementation for
tsh vnet
, with a goal of making it very easy to implement in Connect as well, theAppProvider
interface is mostly modelled around the APIs available in Connect and what is already does for app gateways.lib/vnet/vnet_test.go
exercises the app resolver and alpn dialing, but it does not exercise any of thetsh
code, I'll be adding integration tests for that later.