Add DeviceTrust badge when session upgraded #41029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
avatus
added
the
no-changelog
avatus
force-pushed
the
avatus/device_badge
branch
from
85e9be3 to
ec09f25
Compare
kimlisa
reviewed
Apr 30, 2024
web/packages/teleport/src/components/Authenticated/Authenticated.tsx
Outdated
Show resolved
Hide resolved
|
@kimlisa updated and reverted the |
kimlisa
approved these changes
Apr 30, 2024
rudream
approved these changes
Apr 30, 2024
public-teleport-github-review-bot
bot
removed the request for review
from codingllama
avatus
force-pushed
the
avatus/device_badge
branch
from
5d9a30a to
d162509
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a badge if the
webSessionhas been upgraded with Device Trust.This updates our
statuscheck to include a new field,hasDeviceExtensionswhich returns true if the certificate for the websession have been extended with device trust extensions. In order to not have to "wait" for the first status check, I've changed the initialvalidateCookieAndSessionto just befetchStatus. For some reason, we did a barevalidateCookieAndSessionand then called it again infetchStatusevery time after.If the session is valid, the shield icon will appear (with a hover text shown in screenshot)
