Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "agent ports" Networking Reference section #41021

Merged
merged 1 commit into from
May 30, 2024
Merged

Update "agent ports" Networking Reference section #41021

merged 1 commit into from
May 30, 2024

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Apr 29, 2024

The current guide suggests that you can connect directly to the Windows Desktop Service in order to access a desktop, but this is incorrect. Change the section to provide a more accurate description of direct agent dialling.

Since we recommend joining agents to a cluster via the Proxy Service, this change also adds direct dialling information to a Details box.

@ptgott ptgott added backport/branch/v15 no-changelog Indicates that a PR does not require a changelog entry labels Apr 29, 2024
@github-actions github-actions bot requested review from r0mant, xinding33 and zmb3 April 29, 2024 18:59
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-oy3wsm9ct-goteleport.vercel.app/docs/ver/preview

zmb3
zmb3 reviewed Apr 29, 2024
View reviewed changes
docs/pages/reference/networking.mdx Outdated Show resolved Hide resolved
docs/pages/reference/networking.mdx Outdated Show resolved Hide resolved
@ptgott ptgott force-pushed the paul.gottschling/2024-04-29-direct branch from 3adb8ce to afc5a9e Compare April 29, 2024 19:54
@ptgott
Copy link
Contributor Author

ptgott commented Apr 29, 2024

Edited in afc5a9edbfb8e66554954966d4ce6be1f2680b06

@ptgott ptgott requested a review from zmb3 April 29, 2024 19:54
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-pviuznd88-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/2024-04-29-direct branch from afc5a9e to a777a91 Compare April 30, 2024 14:46
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-knw1fji9b-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/2024-04-29-direct branch from a777a91 to 0d0b00f Compare May 6, 2024 13:38
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

🤖 Vercel preview here: https://docs-64bfdhckd-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/2024-04-29-direct branch from 0d0b00f to 5830edf Compare May 9, 2024 13:39
@ptgott
Copy link
Contributor Author

ptgott commented May 9, 2024

@zmb3 Circling back to see if I've resolved your feedback. Thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

🤖 Vercel preview here: https://docs-djq82axgu-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/2024-04-29-direct branch from 5830edf to d2a8203 Compare May 13, 2024 15:13
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-g96la2w5d-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/2024-04-29-direct branch from d2a8203 to 2ea155b Compare May 14, 2024 18:11
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-ajljpa0ag-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/2024-04-29-direct branch from 2ea155b to 9ee6632 Compare May 15, 2024 19:18
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-3s98r4j8m-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/2024-04-29-direct branch from 9ee6632 to c28f80c Compare May 16, 2024 21:10
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-flzowhp8w-goteleport.vercel.app/docs/ver/preview

@ptgott
Copy link
Contributor Author

ptgott commented May 22, 2024

@zmb3 Following up to see if I have resolved your feedback. Thanks!

@ptgott ptgott enabled auto-merge May 24, 2024 19:44
@ptgott ptgott force-pushed the paul.gottschling/2024-04-29-direct branch from c28f80c to 7909e0c Compare May 30, 2024 18:37
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-5x8qugr2j-goteleport.vercel.app/docs/ver/preview

@ptgott
Update "agent ports" Networking Reference section
5d8a466 
The current guide suggests that you can connect directly to the Windows
Desktop Service in order to access a desktop, but this is incorrect.
Change the section to provide a more accurate description of direct
agent dialling.

Since we recommend joining agents to a cluster via the Proxy Service,
this change also adds direct dialling information to a `Details` box.
@ptgott ptgott force-pushed the paul.gottschling/2024-04-29-direct branch from 7909e0c to 5d8a466 Compare May 30, 2024 19:21
@ptgott ptgott added this pull request to the merge queue May 30, 2024
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-8xb278l3f-goteleport.vercel.app/docs/ver/preview

Merged via the queue into master with commit 79d2a27 May 30, 2024
38 checks passed
@ptgott ptgott deleted the paul.gottschling/2024-04-29-direct branch May 30, 2024 19:37
@public-teleport-github-review-bot
Copy link

@ptgott See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenGravy stevenGravy stevenGravy approved these changes

@zmb3 zmb3 zmb3 approved these changes

@r0mant r0mant Awaiting requested review from r0mant

@xinding33 xinding33 Awaiting requested review from xinding33

Assignees
No one assigned
Labels
backport/branch/v15 backport/branch/v16 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptgott @zmb3 @stevenGravy