Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial access monitoring rules docs #41012

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Add initial access monitoring rules docs #41012

merged 1 commit into from
Jun 12, 2024

Conversation

EdwardDowling
Copy link
Contributor

@EdwardDowling EdwardDowling commented Apr 29, 2024 •
edited
Loading

Add access monitoring rules docs
Part of 3132

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-hzsa1wzfx-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling mentioned this pull request May 8, 2024
Merged
@EdwardDowling EdwardDowling marked this pull request as ready for review May 24, 2024 16:52
@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

r0mant
r0mant requested changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwardDowling I think this guide is missing a couple of things:

  • The guide shows an example monitoring rule but not how/where to create it. It should explain to users how to create it using UI and CLI.
  • A few examples of how to create rules for different scenarios would also be helpful. Right now it mentions "predicate expressions" but no explanation of what they are or how to write them.

@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

1 similar comment
@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@EdwardDowling EdwardDowling added the no-changelog Indicates that a PR does not require a changelog entry label May 30, 2024
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-75ggkntc7-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-6t1eoho8w-goteleport.vercel.app/docs/ver/preview

ptgott
ptgott reviewed May 30, 2024
View reviewed changes
docs/pages/access-controls/access-request-plugins/access-monitoring-rules.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/access-request-plugins/access-monitoring-rules.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/access-request-plugins/access-monitoring-rules.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/access-request-plugins/access-monitoring-rules.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/access-request-plugins/access-monitoring-rules.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/access-request-plugins/access-monitoring-rules.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/access-request-plugins/access-monitoring-rules.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/access-request-plugins/access-monitoring-rules.mdx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

🤖 Vercel preview here: https://docs-jy5dyh2k7-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

🤖 Vercel preview here: https://docs-2c73c62pa-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

🤖 Vercel preview here: https://docs-kl1codubu-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-g3e53uiwv-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-cgcq4dbh3-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling requested a review from zmb3 June 11, 2024 14:45
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-nfwakx2mj-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-xewoqpe2o-goteleport.vercel.app/docs/ver/preview

zmb3
zmb3 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks.

Please squash the commits prior to merging this so we don't get a massive commit message that describes a bunch of work-in-progress states.

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-7tlew4za5-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-lpo2e1t32-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling force-pushed the edwarddowling/access-monitoring-rules-docs branch from cfb3fa4 to f5befa1 Compare June 12, 2024 11:43
@EdwardDowling EdwardDowling enabled auto-merge June 12, 2024 11:43
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-14sk6tc01-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling added this pull request to the merge queue Jun 12, 2024
Merged via the queue into master with commit e9f5ceb Jun 12, 2024
38 checks passed
@EdwardDowling EdwardDowling deleted the edwarddowling/access-monitoring-rules-docs branch June 12, 2024 12:11
@public-teleport-github-review-bot
Copy link

@EdwardDowling See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Create PR

This was referenced Jun 12, 2024
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmb3 zmb3 zmb3 approved these changes

@r0mant r0mant r0mant approved these changes

@ptgott ptgott Awaiting requested review from ptgott

Assignees
No one assigned
Labels
backport/branch/v15 backport/branch/v16 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EdwardDowling @r0mant @zmb3 @ptgott