Integration: Allow empty regions #40984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tener
approved these changes
Apr 29, 2024
marcoandredinis
approved these changes
Apr 29, 2024
When using AWS Integration to access global services, the region is not required. PR #40188 introduced a validation of the region which caused troubles when using the integration with empty regions like when accessing the STS endpoint to discover the AWS AccountID. Signed-off-by: Tiago Silva <[email protected]>
tigrato
force-pushed
the
tigrato/integration-allow-empty-region
branch
from
a1e1b1f to
887152d
Compare
ryanclark
approved these changes
Apr 29, 2024
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using AWS Integration to access global services, the region is not required. PR #40188 introduced a validation of the region which caused troubles when using the integration with empty regions like when accessing the STS endpoint to discover the AWS AccountID.
Changelog: Allow AWS integration to be used for global services without specifying a valid region.