allow attaching to pods in kube integration tests #40971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capnspacehook
added
the
no-changelog
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Failed |
Infrastructure as Code |  1  3  1  1 |
View in Orca |
 Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
|
Controller of pods with role that allows the creation or modification of other pods | ...bac/ci-teleport.yaml | View in code |
|
RBAC Roles with Attach Permission | ...bac/ci-teleport.yaml | View in code |
|
Controller of pods with role that allows attaching or executing commands inside a pod | ...bac/ci-teleport.yaml | View in code |
|
RBAC Roles with Port-Forwarding Permission | ...bac/ci-teleport.yaml | View in code |
|
Controller of pods with impersonation privileges service account | ...bac/ci-teleport.yaml | View in code |
|
Ensure Administrative Boundaries Between Resources | ...bac/ci-teleport.yaml | View in code |
tigrato
approved these changes
Apr 26, 2024
AntonAM
approved these changes
Apr 26, 2024
public-teleport-github-review-bot
bot
removed request for
Joerger and
smallinsky
capnspacehook
deleted the
capnspacehook/kube-waiting-conts-attach-test-perms
branch
|
@capnspacehook See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestKube/EphemeralContainerscreates an ephemeral container that runs a short lived commandecho ...and has a moderator join the session. Most of the time the command in the container will have finished before the users have a chance to attach to it, but sometimes that's not the case.Fixes #40969.