Skip flaky access plugin tests #40525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
hugoShaka
added
the
no-changelog
marcoandredinis
approved these changes
Apr 12, 2024
tigrato
approved these changes
Apr 12, 2024
public-teleport-github-review-bot
bot
removed the request for review
from r0mant
zmb3
approved these changes
Apr 12, 2024
hugoShaka
force-pushed
the
hugo/skip-flaky-e-access-plugin-tests
branch
from
556814a to
0075d75
Compare
hugoShaka
added a commit
that referenced
this pull request
Apr 23, 2024
* Skip flaky access plugin tests * fixup! Skip flaky access plugin tests
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
* Copy Terraform provider from teleport-plugins repo (#40224) * copy terraform provider * Make dependecy checker happy + use go 1.22 * Run terraform tests in the CI, add Makefile target * go mod tidy * Migrate Slack access plugin tests (#38427) * Migrate ServiceNow access plugin tests (#38413) * Migrate ServiceNow access plugin tests * lint * Migrate pagerduty access plugin tests (#38412) * Migrate opsgenie access plugin tests (#38410) * Migrate mattermost access plugin tests (#38408) * Migrate discord access plugin tests (#38405) * Migrate jira access plugin tests (#38406) * Migrate jira access plugin tests * grant the access_request.update permission * lint * license * Vendor teleport-event-handler (#40364) * Vendor event-forwarder plugin * fix tests + add Makefile + CI * lint * Fix broken test * use a separate go.mod * ignore event-handler in flaky tests + update go.mod * go mod tidy * fix TF go mod * Fix path filtering in unit (integrations) CI (#40488) * fix broken path filtering in workflow * go mod tidy * Prepare teleport access plugin enterprise test suite (#40479) * Make AuthHelper support enterprise * Split access OSS and Enterprise tets suites * fix slack tests * fix race in accesslist reminder tests * fixup! fix race in accesslist reminder tests * Skip flaky access plugin tests (#40525) * Skip flaky access plugin tests * fixup! Skip flaky access plugin tests * Lint Terraform and Event-Handler (#40604) * Lint Terraform and Event-Handler * lint terraform * add Makefile lint targets for TF and event-handler * address feedback * Update integrations/event-handler/Makefile Co-authored-by: Alan Parra <[email protected]> --------- Co-authored-by: Alan Parra <[email protected]> * Split Terraform OSS and enterprise test suites (#40534) * Split TF oss and TF ent tests * Add makefile target + use eintegration * update go mod * Vendor plugin charts (#40373) * vendor plugin charts * add tests and version update * re-generate go modules * tolerate-ghsa * bump helm to 3.14.3 to appease the dependency reviewer * reduce go version to 1.21 * tidy after rebase --------- Co-authored-by: Alan Parra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v14, we started to move the access plugin lib code in the teleport repo but did not enterprise tests.
I want to enable access plugin enterprise tests back but some race tests are flaky.
The flakiness is not due to a bug in the access plugin but the test itself; since we are running in-process teleport, tests are faster, and sometimes the plugin makes a single API call to update a message reflecting 2 approvals. This breaks the race tests as they expect X updates to be sent.
I need to rewrite those tests to be state-based instead of trigger-based (look at the final Slack message update instead of expecting X updates, with potentially the wrong content in the last one). In the meantime, I still want to run all the other enterprise tests, hence this PR to disable the flaky ones.