Fix tpm joining protobuf oneof #40514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
strideynet
added
the
no-changelog
codingllama
reviewed
Apr 12, 2024
codingllama
approved these changes
Apr 12, 2024
marcoandredinis
approved these changes
Apr 12, 2024
public-teleport-github-review-bot
bot
removed request for
probakowski and
fheinecke
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Apr 15, 2024
* Fix tpm joining protobuf oneof * See if Buf will allow me to reuse the indexes outside of oneof * Regen protos * Tactical renaming * Update CRDs
strideynet
added a commit
that referenced
this pull request
Apr 15, 2024
* Fix tpm joining protobuf oneof * See if Buf will allow me to reuse the indexes outside of oneof * Regen protos * Tactical renaming * Update CRDs
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These protos aren't in use yet - I made a small mistake in the original PR by using a oneof. As far as I can tell, there's some weirdness around
oneofand GoGoProto/jsonpb/protojson, and I'd prefer to avoid that footgun if I can.