-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Connect Enterprise entry point #40477
Conversation
…be customized in Connect Enterprise
// from Connect OSS package.json when it is run in the enterprise app context | ||
// (it simply reads the direct package.json content). | ||
// We have to provide them manually. | ||
include: Object.keys(packageJson.dependencies), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if teleterm.e needs to depend on deps that teleterm doesn't depend on? teleport.e already depends on extra deps, so sooner or later teleterm.e will have its own deps as well.
Overall this looks okay, barring the question of teleterm.e specific deps. But I just raised a question on Slack if we even need teleterm.e in the first place. |
We will move access requests to OSS and get rid of teleterm.e. |
The first step of #17706.
e counterpart https://github.com/gravitational/teleport.e/pull/3946
A few notes:
externalizeDepsPlugin
can no longer be resolved automatically, because they are read from the directpackage.json
so teleterm.e package.json doesn't have them.@gravitational/teleterm
as a dependency to@gravitational/teleterm.e
the app has grown 3x times because it just copied@gravitational/teleterm
to the app package. I believe it happens somwhere in app-builder, but I didn't find a way to passexcludedDependencies
there.'!**/node_modules/@gravitational/teleterm/**'
infiles
. Seems to work fine, both OSS and Enterprise DMGs are now ~128.5 MB.@ravicious you mentioned in your WIP PR this:
How important it is? I quickly tried excluding it with
!build_resources
and it resulted in 3 KB size difference, so I'm not sure if I should dig there.