[Web] Add support for enterprise-only notifications #40264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
no-changelog
gzdunek
approved these changes
Apr 10, 2024
web/packages/teleport/src/Notifications/notificationContentFactory.tsx
Outdated
Show resolved
Hide resolved
avatus
approved these changes
Apr 10, 2024
rudream
force-pushed
the
yassine/notifications/ui-list
branch
from
7b9212e to
3e4c764
Compare
rudream
force-pushed
the
yassine/notifications/enterprise-routes
branch
from
649164b to
4b3963b
Compare
rudream
force-pushed
the
yassine/notifications/ui-list
branch
4 times, most recently
from
c76a771 to
c1813df
Compare
rudream
force-pushed
the
yassine/notifications/enterprise-routes
branch
from
4b3963b to
80f8849
Compare
rudream
force-pushed
the
yassine/notifications/enterprise-routes
branch
from
80f8849 to
9d26a88
Compare
rudream
added a commit
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #37704
Adds support for enterprise-only notifications. This is so that we can configure notifications to redirect to enterprise-only routes.
For example, clicking an access request notification should take you to the access request's page, however this route isn't available in OSS, so it needs to be defined in
e.This PR is based on changes from:
Implementation
The
TeleportContexthas anotificationsContentFactorymethod which will by default be the base OSSnotificationsContentFactory, however if the user is running enterprise, this method in the context will be overwritten bynotificationsContentFactoryEwhich adds support for enterprise notifications.The
NotificationTypesstory in the OSS Storybook will only display OSS notifications, while theNotificationTypesEstory will support all notification types. I considered only having theNotification Types Estory, but I thought it might be useful to have the OSS one as well in case an open-source contributor would like to add a new notification type to Teleport.